Bug #236

Include path issues (Haiku/3rdparty build)

Added by Joe Prostko over 1 year ago. Updated over 1 year ago.

Status:Closed Start:03/30/2009
Priority:Normal Due date:
Assigned to:Pier Luigi Fiorini % Done:

50%
Category:Build system Spent time: 0.10 hour
Target version:0.9.2
Operating System:Haiku

Description

I believe I encountered this issue in the past, but kind of forgot about it until I checked out the repository again tonight.

The Jamfile.haiku files in libs/libjammer, protocols/MSN, protocols/GoogleTalk, and protocols/Oscar all have a line that is no longer correct.

local sslDir = [ FDirName $(HAIKU_OUTPUT_DIR) cross-ssl config ] ;

should read as:

local sslDir = [ FDirName $(HAIKU_OUTPUT_DIR) cross-ssl common ] ;

"config" used to be correct in the past (when OpenSSL 0.9.8g was the newest available for Haiku), but over time and with the availability of OpenSSL 0.9.8j, using "common" is now preferred.

In other words, the current Jamfile.haiku files work with the 0.9.8g zip on haiku-files.org, but the change from "config" to "common" is needed for use with the 0.9.8j zip.

Also, with r862 of the IMKit, the build breaks, due to an include issue in sample_clients/im_infopopper/IMInfoApp.h and sample_clients/im_infopopper/main.cpp.

Both now have an include line of

#include <infopopper/InfoPopper.h>

when they should have

#include <libinfopopper/InfoPopper.h>

Reverting back to 861 fixes this issue, although I don't know if future changes of instances of "libinfopopper" to "infopopper" in InfoPopper are planned, and then will make r862 subsequently correct.

History

Updated by Pier Luigi Fiorini over 1 year ago

  • Status changed from New to Assigned
  • Target version set to 0.9.2

Updated by Joe Prostko over 1 year ago

Just wanted to mention, that with r864 I encountered a couple more include issues while doing a 3rdparty build. They do not make any sense to me, since the includes are to files in the same exact directory, yet for some reason the common directory needs to be referred to.

I will expound below...

For some reason, the build fails due to includes in common/SpecificationFinder.h.

Changing the lines

#include "GenericStore.h"
#include "Specification.h"

to

#include "common/GenericStore.h"
#include "common/Specification.h"

fixes the build, but as I said, this confuses me, since the files are in the same directory as SpecificationFinder.h.

After this was addressed, the build broke as mentioned in bug 240.

Updated by Michael Davidson over 1 year ago

  • Status changed from Assigned to Feedback
  • % Done changed from 0 to 50

I have modified the include paths in R879 and Bug #240 has been resolved.

Is this still an issue?

Updated by Joe Prostko over 1 year ago

Okay, I did a clean checkout of r879, and while doing a 3rdparty build using r30111 of Haiku, and building InfoPopper (clean checkout of r129) at the same time, I encountered the following problem (which also occurred as mentioned in the original ticket summary).

C++ generated/objects/haiku/x86/release/IMKit/sample_clients/im_infopopper/main.o
In file included from 3rdparty/IMKit/sample_clients/im_infopopper/main.cpp:1:
3rdparty/IMKit/sample_clients/im_infopopper/IMInfoApp.h:17: infopopper/InfoPopper.h: No such file or directory
3rdparty/IMKit/sample_clients/im_infopopper/main.cpp:5: infopopper/InfoPopper.h: No such file or directory

This was remedied by changing "infopopper/Infopopper.h" to "libinfopopper/Infopopper.h" in IMInfoApp.h and main.cpp, as mentioned previously.

After fixing those includes, everything builds fine. Once you get those changed (or if you end up changing the name of the directory in InfoPopper from libinfopopper to infopopper), feel free to close this bug.

For reference, the following is at the bottom of my ReleaseBuildProfile, just so you are assured I am doing things correctly to accomplish a 3rdparty build of IMKit along with InfoPopper.

  1. Adding InfoPopper and IMKit
    IMKIT_HAVE_INFOPOPPER = 1 ;
    DeferredSubInclude HAIKU_TOP 3rdparty InfoPopper : Jamfile.haiku ;
    DeferredSubInclude HAIKU_TOP 3rdparty IMKit : Jamfile.haiku ;

Updated by Joe Prostko over 1 year ago

Feel free to close this ticket.

My remaining issues (the InfoPopper include file problems) are resolved by following updated directions in r912's Build-3rdparty.txt.

Updated by Michael Davidson over 1 year ago

  • Status changed from Feedback to Closed

Also available in: Atom PDF